Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for lyrics without timestamp #545

Merged
merged 1 commit into from
Oct 17, 2024
Merged

Fix for lyrics without timestamp #545

merged 1 commit into from
Oct 17, 2024

Conversation

SO9010
Copy link
Contributor

@SO9010 SO9010 commented Oct 17, 2024

Fix #544 by detecting if the song lyrics time is set at 0.

@SO9010 SO9010 marked this pull request as ready for review October 17, 2024 13:17
jacksongoode
jacksongoode approved these changes Oct 17, 2024
View reviewed changes
Copy link
Collaborator

@jacksongoode jacksongoode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@jacksongoode jacksongoode changed the title Fix for lyrics Fix for lyrics without timestamp Oct 17, 2024
@jacksongoode jacksongoode merged commit b3c56fd into jpochyla:main Oct 17, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jacksongoode jacksongoode jacksongoode approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Some song lyircs link to start of song
2 participants
@SO9010 @jacksongoode